Skip to content

tidy up some remaining PyO3 GIL Refs #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2024
Merged

tidy up some remaining PyO3 GIL Refs #1225

merged 1 commit into from
Mar 13, 2024

Conversation

davidhewitt
Copy link
Contributor

Change Summary

Followup to #1222. Found a few corner cases of GIL refs which needed removing.

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Copy link

codspeed-hq bot commented Mar 12, 2024

CodSpeed Performance Report

Merging #1225 will not alter performance

Comparing dh/tidy-gil-refs (e1d9535) with main (71d54a2)

Summary

✅ 148 untouched benchmarks

@davidhewitt davidhewitt merged commit 10095b5 into main Mar 13, 2024
@davidhewitt davidhewitt deleted the dh/tidy-gil-refs branch March 13, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant