Skip to content

Improve test_valid_complex_string_with_space() xfail condition #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Sep 6, 2024

Change Summary

Improve the xfail condition for test_valid_complex_string_with_space() to use PyPy version rather than Python version. This corresponds to the fact that the issue was fixed in 7.3.17 releases. The other condition works only because PyPy3.9 is no longer being developed, and therefore did not get a 7.3.17 release.

Related issue number

This improves #1439, as discussed in comments.

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Improve the xfail condition for `test_valid_complex_string_with_space()`
to use PyPy version rather than Python version.  This corresponds
to the fact that the issue was fixed in 7.3.17 releases.  The other
condition works only because PyPy3.9 is no longer being developed,
and therefore did not get a 7.3.17 release.
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.29%. Comparing base (ab503cb) to head (c295fb2).
Report is 170 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1441      +/-   ##
==========================================
- Coverage   90.21%   89.29%   -0.93%     
==========================================
  Files         106      112       +6     
  Lines       16339    17724    +1385     
  Branches       36       41       +5     
==========================================
+ Hits        14740    15826    +1086     
- Misses       1592     1878     +286     
- Partials        7       20      +13     

see 49 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dec5faa...c295fb2. Read the comment docs.

Copy link

codspeed-hq bot commented Sep 6, 2024

CodSpeed Performance Report

Merging #1441 will not alter performance

Comparing mgorny:pypy-xfail (c295fb2) with main (dec5faa)

Summary

✅ 155 untouched benchmarks

@sydney-runkle sydney-runkle merged commit 6169ea9 into pydantic:main Sep 6, 2024
29 checks passed
@mgorny mgorny deleted the pypy-xfail branch September 6, 2024 09:31
@mgorny
Copy link
Contributor Author

mgorny commented Sep 6, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants