Skip to content

pass --uv flag to maturin develop #1591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ install-rust-coverage:
build-dev:
@rm -f python/pydantic_core/*.so
ifneq ($(USE_MATURIN),)
uv run maturin develop
uv run maturin develop --uv
else
uv pip install --force-reinstall -v -e . --config-settings=build-args='--profile dev'
endif
Expand All @@ -48,7 +48,7 @@ endif
build-prod:
@rm -f python/pydantic_core/*.so
ifneq ($(USE_MATURIN),)
uv run maturin develop --release
uv run maturin develop --uv --release
else
uv pip install -v -e .
endif
Expand All @@ -57,7 +57,7 @@ endif
build-profiling:
@rm -f python/pydantic_core/*.so
ifneq ($(USE_MATURIN),)
uv run maturin develop --profile profiling
uv run maturin develop --uv --profile profiling
else
uv pip install --force-reinstall -v -e . --config-settings=build-args='--profile profiling'
endif
Expand All @@ -66,7 +66,7 @@ endif
build-coverage:
@rm -f python/pydantic_core/*.so
ifneq ($(USE_MATURIN),)
RUSTFLAGS='-C instrument-coverage' uv run maturin develop --release
RUSTFLAGS='-C instrument-coverage' uv run maturin develop --uv --release
else
RUSTFLAGS='-C instrument-coverage' uv pip install -v -e .
endif
Expand All @@ -76,15 +76,15 @@ build-pgo:
@rm -f python/pydantic_core/*.so
$(eval PROFDATA := $(shell mktemp -d))
ifneq ($(USE_MATURIN),)
RUSTFLAGS='-Cprofile-generate=$(PROFDATA)' uv run maturin develop --release
RUSTFLAGS='-Cprofile-generate=$(PROFDATA)' uv run maturin develop --uv --release
else
RUSTFLAGS='-Cprofile-generate=$(PROFDATA)' uv pip install --force-reinstall -v -e .
endif
pytest tests/benchmarks
$(eval LLVM_PROFDATA := $(shell rustup run stable bash -c 'echo $$RUSTUP_HOME/toolchains/$$RUSTUP_TOOLCHAIN/lib/rustlib/$$(rustc -Vv | grep host | cut -d " " -f 2)/bin/llvm-profdata'))
$(LLVM_PROFDATA) merge -o $(PROFDATA)/merged.profdata $(PROFDATA)
ifneq ($(USE_MATURIN),)
RUSTFLAGS='-Cprofile-use=$(PROFDATA)/merged.profdata' uv run maturin develop --release
RUSTFLAGS='-Cprofile-use=$(PROFDATA)/merged.profdata' uv run maturin develop --uv --release
else
RUSTFLAGS='-Cprofile-use=$(PROFDATA)/merged.profdata' uv pip install --force-reinstall -v -e .
endif
Expand Down
2 changes: 1 addition & 1 deletion uv.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading