Set info.data and info.field_name for dataclass field validators

[adriangb]

No description provided.

[codecov-commenter]

Codecov Report

Merging #454 (d373e11) into main (653308f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #454   +/-   ##
=======================================
  Coverage   95.36%   95.37%           
=======================================
  Files          93       93           
  Lines       11115    11124    +9     
  Branches       22       22           
=======================================
+ Hits        10600    10609    +9     
  Misses        510      510           
  Partials        5        5           

Impacted Files	Coverage Δ
src/validators/dataclass.rs	97.53% <100.00%> (+0.08%)	⬆️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 653308f...d373e11. Read the comment docs.

[codspeed-hq]

CodSpeed Performance Report

Merging #454 dataclass-fields (d373e11) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 93 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

[samuelcolvin]

LGTM

[dmontagu]

This seems necessary, but do we have any benchmarks that would pick up on performance impact of this? Not sure it matters.

[dmontagu]

Looks good to me with the only possible concern being the creation of more Extra for each field of the dataclass. Not sure if that is avoidable in theory, or how expensive it is to create an Extra anyway.

I think if there's any interest in eliminating the copying of Extra (e.g., if it were expensive to create copies for some reason, I haven't looked at the definition so I'm not sure), at this stage it would make sense to just put a comment indicating this in the code and revisit at a later time rather than put effort into eliminating the copying now.

[dmontagu]

Okay I looked it up, considering Extra is just four optional references and a bool I think performance impact should be pretty negligible.

[adriangb]

It's also what we already do elsewhere:

pydantic-core/src/validators/typed_dict.rs

Lines 189 to 193 in 653308f

	let extra = Extra {
	data: Some(output_dict),
	field_name: Some(&field.name),
	..*extra
	};