Skip to content

use LiteralString on PydanticCustomError #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2023

Conversation

samuelcolvin
Copy link
Member

@samuelcolvin samuelcolvin commented Apr 28, 2023

to avoid temptation to make error_type and particularly message_template dynamic, might require a few type-ignores, but that's fine.

Noticed while reviewing pydantic/pydantic#5599.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 28, 2023

CodSpeed Performance Report

Merging #562 PydanticCustomError-LiteralString (bd257d8) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 111 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2023

Codecov Report

Merging #562 (bd257d8) into main (4f1ce33) will increase coverage by 0.07%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #562      +/-   ##
==========================================
+ Coverage   94.13%   94.20%   +0.07%     
==========================================
  Files          94       94              
  Lines       12762    12762              
  Branches       24       24              
==========================================
+ Hits        12013    12022       +9     
+ Misses        743      734       -9     
  Partials        6        6              

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f1ce33...bd257d8. Read the comment docs.

@samuelcolvin samuelcolvin force-pushed the PydanticCustomError-LiteralString branch from 03bba88 to bd257d8 Compare April 30, 2023 10:10
@samuelcolvin samuelcolvin merged commit c9f45e3 into main Apr 30, 2023
@samuelcolvin samuelcolvin deleted the PydanticCustomError-LiteralString branch April 30, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants