Skip to content

separate model fields validator from typed dict validator #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 2, 2023

Conversation

samuelcolvin
Copy link
Member

No description provided.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 30, 2023

CodSpeed Performance Report

Merging #568 model_fields (3bb9102) will not alter performances.

Summary

🔥 0 improvements
❌ 1 regressions
✅ 110 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

Benchmarks breakdown

Benchmark main model_fields Change
test_complete_core_json 2.5 ms 2.8 ms -10.01%

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2023

Codecov Report

Merging #568 (cc85a5f) into custom_init2 (2a3d37e) will increase coverage by 0.11%.
The diff coverage is 97.95%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@               Coverage Diff                @@
##           custom_init2     #568      +/-   ##
================================================
+ Coverage         94.15%   94.26%   +0.11%     
================================================
  Files                94       95       +1     
  Lines             12796    12937     +141     
  Branches             24       24              
================================================
+ Hits              12048    12195     +147     
+ Misses              742      736       -6     
  Partials              6        6              
Impacted Files Coverage Δ
src/serializers/shared.rs 90.38% <ø> (ø)
src/serializers/type_serializers/model.rs 93.06% <93.10%> (+0.01%) ⬆️
src/validators/model.rs 98.38% <96.42%> (+0.04%) ⬆️
src/validators/model_fields.rs 98.70% <98.70%> (ø)
pydantic_core/core_schema.py 96.95% <100.00%> (+0.09%) ⬆️
src/argument_markers.rs 91.83% <100.00%> (+0.34%) ⬆️
src/input/input_abstract.rs 87.87% <100.00%> (ø)
src/input/input_python.rs 98.74% <100.00%> (ø)
src/validators/mod.rs 98.82% <100.00%> (+<0.01%) ⬆️
src/validators/typed_dict.rs 99.11% <100.00%> (+0.72%) ⬆️
... and 1 more

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a3d37e...cc85a5f. Read the comment docs.

@samuelcolvin samuelcolvin changed the base branch from custom_init2 to main May 2, 2023 16:18
@samuelcolvin samuelcolvin merged commit 817af72 into main May 2, 2023
@samuelcolvin samuelcolvin deleted the model_fields branch May 2, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants