Skip to content

Assume wrap validators produce the same serialization schema #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2023

Conversation

dmontagu
Copy link
Collaborator

@dmontagu dmontagu commented May 2, 2023

This is now ready for review.

@dmontagu dmontagu requested a review from adriangb May 2, 2023 20:16
@dmontagu dmontagu force-pushed the assume-wrap-validator-has-same-ser-schema branch from 4ef3ecf to 106b641 Compare May 2, 2023 20:17
@codspeed-hq
Copy link

codspeed-hq bot commented May 2, 2023

CodSpeed Performance Report

Merging #573 assume-wrap-validator-has-same-ser-schema (be81316) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 112 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2023

Codecov Report

Merging #573 (ef7b7cc) into main (119b265) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #573   +/-   ##
=======================================
  Coverage   94.17%   94.17%           
=======================================
  Files          95       95           
  Lines       12970    12972    +2     
  Branches       24       24           
=======================================
+ Hits        12214    12216    +2     
  Misses        750      750           
  Partials        6        6           
Impacted Files Coverage Δ
src/serializers/type_serializers/function.rs 95.71% <100.00%> (+0.02%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 119b265...ef7b7cc. Read the comment docs.

@dmontagu dmontagu force-pushed the assume-wrap-validator-has-same-ser-schema branch from 106b641 to ef7b7cc Compare May 3, 2023 17:23
@dmontagu dmontagu marked this pull request as ready for review May 3, 2023 17:48
@dmontagu dmontagu requested a review from samuelcolvin May 3, 2023 21:34
@dmontagu dmontagu merged commit 944bf91 into main May 4, 2023
@dmontagu dmontagu deleted the assume-wrap-validator-has-same-ser-schema branch May 4, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants