Skip to content

simplify serialization filtering #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2023

Conversation

samuelcolvin
Copy link
Member

mostly improvements to excluding fields on typeddict, dataclass args and model fields.

@codecov-commenter
Copy link

Codecov Report

Merging #578 (ce6e813) into main (119b265) will decrease coverage by 0.01%.
The diff coverage is 96.66%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #578      +/-   ##
==========================================
- Coverage   94.17%   94.16%   -0.01%     
==========================================
  Files          95       95              
  Lines       12970    12949      -21     
  Branches       24       24              
==========================================
- Hits        12214    12193      -21     
  Misses        750      750              
  Partials        6        6              
Impacted Files Coverage Δ
src/serializers/filter.rs 95.49% <ø> (-0.18%) ⬇️
src/serializers/type_serializers/model.rs 92.92% <75.00%> (-0.15%) ⬇️
src/serializers/type_serializers/dataclass.rs 100.00% <100.00%> (ø)
src/serializers/type_serializers/typed_dict.rs 94.73% <100.00%> (-0.18%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 119b265...ce6e813. Read the comment docs.

@samuelcolvin
Copy link
Member Author

I'll merge this once it's passing as I need it to continue with #576.

@codspeed-hq
Copy link

codspeed-hq bot commented May 3, 2023

CodSpeed Performance Report

Merging #578 simplify-serialization-filtering (ce6e813) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 112 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

@samuelcolvin samuelcolvin merged commit d3f97e7 into main May 4, 2023
@samuelcolvin samuelcolvin deleted the simplify-serialization-filtering branch May 4, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants