Skip to content

🙈 Add /.pdm-python to git ignore #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2023
Merged

Conversation

lig
Copy link
Contributor

@lig lig commented May 4, 2023

  • Add /.pdm-python to .gitignore as it is being automatically created by pdm
  • Rearrange .gitignore to make it more readable

@codspeed-hq
Copy link

codspeed-hq bot commented May 4, 2023

CodSpeed Performance Report

Merging #579 pdm-python-to-gitignore (f872c1e) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 112 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

@lig
Copy link
Contributor Author

lig commented May 4, 2023

please review

@lig lig requested a review from samuelcolvin May 4, 2023 11:19
@samuelcolvin samuelcolvin enabled auto-merge (squash) May 4, 2023 14:40
@samuelcolvin samuelcolvin merged commit bfc74d7 into main May 4, 2023
@samuelcolvin samuelcolvin deleted the pdm-python-to-gitignore branch May 4, 2023 14:41
@samuelcolvin
Copy link
Member

thanks.

@adriangb
Copy link
Member

adriangb commented May 4, 2023

but we're not even using PDM in this repo. Wrong repo folks?

@lig
Copy link
Contributor Author

lig commented May 4, 2023

🤦🏻‍♂️ anyways, it helps now to use it. I've created a venv using PDM, ran tests like in the pydantic repo, and it worked. The only thing was the .pdm-python file dangling in the repo. 🤷🏻‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants