Skip to content

✨ Implement root model serialization #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2023
Merged

Conversation

lig
Copy link
Contributor

@lig lig commented May 19, 2023

Implement serialization for root model. Required for pydantic/pydantic#5765

Deduplicated some related error messages to simplify debugging.

Selected Reviewer: @adriangb

@lig lig requested review from samuelcolvin and dmontagu May 19, 2023 11:53
@codspeed-hq
Copy link

codspeed-hq bot commented May 19, 2023

CodSpeed Performance Report

Merging #613 5498-add-rootmodel-to-pydantic (306002a) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 119 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

@codecov-commenter
Copy link

Codecov Report

Merging #613 (e33034c) into main (c818c3e) will decrease coverage by 0.03%.
The diff coverage is 84.84%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #613      +/-   ##
==========================================
- Coverage   94.19%   94.17%   -0.03%     
==========================================
  Files          98       98              
  Lines       13189    13204      +15     
  Branches       25       25              
==========================================
+ Hits        12424    12435      +11     
- Misses        759      763       +4     
  Partials        6        6              
Impacted Files Coverage Δ
src/serializers/type_serializers/function.rs 95.14% <68.75%> (-0.58%) ⬇️
src/serializers/type_serializers/model.rs 94.65% <100.00%> (+0.69%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c818c3e...e33034c. Read the comment docs.

@lig lig force-pushed the 5498-add-rootmodel-to-pydantic branch from e33034c to 1a326fd Compare May 19, 2023 16:25
@lig lig force-pushed the 5498-add-rootmodel-to-pydantic branch from 0d2c1b7 to 605604b Compare May 19, 2023 17:59
@lig lig force-pushed the 5498-add-rootmodel-to-pydantic branch from 605604b to 306002a Compare May 19, 2023 18:00
@adriangb
Copy link
Member

please review

@lig lig merged commit 6667c07 into main May 19, 2023
@lig lig deleted the 5498-add-rootmodel-to-pydantic branch May 19, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants