Ignore: add tests to #610 #616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriangb
commented
May 19, 2023
Comment on lines
+135
to
+149
| #[allow(clippy::too_many_arguments)] | ||
| fn validate_tuple_positional<'s, 'data, T: Iterator<Item = PyResult<&'data I>>, I: Input<'data> + 'data>( | ||
| py: Python<'data>, | ||
| input: &'data impl Input<'data>, | ||
| extra: &Extra, | ||
| definitions: &'data Definitions<CombinedValidator>, | ||
| recursion_guard: &'s mut RecursionGuard, | ||
| output: &mut Vec<PyObject>, | ||
| errors: &mut Vec<ValLineError<'data>>, | ||
| extra_validator: &Option<Box<CombinedValidator>>, | ||
| items_validators: &[CombinedValidator], | ||
| collection_iter: &mut T, | ||
| collection_len: Option<usize>, | ||
| expected_length: usize, | ||
| ) -> ValResult<'data, ()> { |
There was a problem hiding this comment.
This is basically what was inside of the macro but it didn't like the iter.map(Ok) pattern because it couldn't infer that the Err variant was a ValResult :(
CodSpeed Performance ReportMerging #616 Summary
Benchmarks breakdown
|
|
This looks the same as #610 performance wise, so merging into there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.