Skip to content

nicer error when hitting recursion error while serializing #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 25, 2023

Conversation

samuelcolvin
Copy link
Member

@samuelcolvin samuelcolvin marked this pull request as ready for review May 24, 2023 18:52
@codspeed-hq
Copy link

codspeed-hq bot commented May 24, 2023

CodSpeed Performance Report

Merging #630 recusion-error-serializing (425647b) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 120 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2023

Codecov Report

Merging #630 (425647b) into main (c9a83c8) will increase coverage by 0.04%.
The diff coverage is 96.42%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #630      +/-   ##
==========================================
+ Coverage   94.02%   94.07%   +0.04%     
==========================================
  Files          98       98              
  Lines       13283    13282       -1     
  Branches       25       25              
==========================================
+ Hits        12490    12495       +5     
+ Misses        787      781       -6     
  Partials        6        6              
Impacted Files Coverage Δ
src/serializers/type_serializers/function.rs 96.53% <96.00%> (+1.38%) ⬆️
src/serializers/errors.rs 87.75% <100.00%> (+2.97%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9a83c8...425647b. Read the comment docs.

@samuelcolvin samuelcolvin merged commit 058a0b8 into main May 25, 2023
@samuelcolvin samuelcolvin deleted the recusion-error-serializing branch May 25, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gracefully handle calls to model_dump inside a @model_serializer
3 participants