Skip to content

Add hide_input to ValidationError #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2023
Merged

Add hide_input to ValidationError #633

merged 1 commit into from
May 25, 2023

Conversation

hramezani
Copy link
Member

@hramezani hramezani commented May 25, 2023

Selected Reviewer: @samuelcolvin

@codspeed-hq
Copy link

codspeed-hq bot commented May 25, 2023

CodSpeed Performance Report

Merging #633 hide_input (b0cabae) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 121 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

@codecov-commenter
Copy link

Codecov Report

Merging #633 (d10493e) into main (26fa27d) will increase coverage by 0.01%.
The diff coverage is 95.08%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #633      +/-   ##
==========================================
+ Coverage   94.04%   94.06%   +0.01%     
==========================================
  Files          98       98              
  Lines       13456    13496      +40     
  Branches       25       25              
==========================================
+ Hits        12655    12695      +40     
  Misses        795      795              
  Partials        6        6              
Impacted Files Coverage Δ
src/build_tools.rs 86.25% <75.00%> (ø)
src/validators/generator.rs 93.75% <93.75%> (+0.41%) ⬆️
src/errors/validation_exception.rs 93.76% <95.45%> (+0.20%) ⬆️
pydantic_core/core_schema.py 96.87% <100.00%> (+<0.01%) ⬆️
src/validators/function.rs 91.22% <100.00%> (+0.18%) ⬆️
src/validators/mod.rs 98.54% <100.00%> (+0.03%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26fa27d...d10493e. Read the comment docs.

@hramezani hramezani force-pushed the hide_input branch 4 times, most recently from 962a6b4 to 9db28fa Compare May 25, 2023 12:46
Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise this is looking really good.

@hramezani
Copy link
Member Author

Please review

@samuelcolvin samuelcolvin merged commit 726ef5f into main May 25, 2023
@samuelcolvin samuelcolvin deleted the hide_input branch May 25, 2023 21:37
@samuelcolvin
Copy link
Member

thanks so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants