-
Notifications
You must be signed in to change notification settings - Fork 292
Use PyInt
for inequality and multiple of checks
#634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance ReportMerging #634 Summary
Benchmarks breakdown
|
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #634 +/- ##
==========================================
- Coverage 94.10% 93.98% -0.12%
==========================================
Files 99 99
Lines 13561 13591 +30
Branches 25 25
==========================================
+ Hits 12762 12774 +12
- Misses 793 811 +18
Partials 6 6
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would really prefer if bigints were just handled more transparently, but this looks fine to me if it's improving other issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall
Ask and thou shall receive - added BigInt support, supports parsing ints ups to 4300 characters - matching the constraints recently added in python. I've also used
|
This degrades performance in the case of inequality checks by around 30%, but if prevents issues with ints over
i64::MAX
.Selected Reviewer: @dmontagu