Skip to content

expand allowed errors from hypothesis test for url parsing #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2023
Merged

expand allowed errors from hypothesis test for url parsing #684

merged 1 commit into from
Jun 22, 2023

Conversation

davidhewitt
Copy link
Contributor

@davidhewitt davidhewitt commented Jun 21, 2023 •
edited by pydantic-hooky bot
Loading

Fixes the following failure in these tests:

AssertionError: assert 'empty host' == 'relative URL without a base'

Selected Reviewer: @adriangb

@davidhewitt
Copy link
Contributor Author

please review

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 21, 2023

CodSpeed Performance Report

Merging #684 dh/multi-host-cases (6888735) will improve performances by 10.71%.

Summary

🔥 1 improvements
❌ 0 regressions
✅ 124 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

Benchmarks breakdown

Benchmark main dh/multi-host-cases Change
🔥 test_set_of_ints_core_json_duplicates 5.8 ms 5.2 ms +10.71%

@davidhewitt davidhewitt merged commit 3139251 into main Jun 22, 2023
@davidhewitt davidhewitt deleted the dh/multi-host-cases branch June 22, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriangb adriangb adriangb approved these changes

Assignees

@adriangb adriangb

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhewitt @adriangb