Skip to content

add PULL_REQUEST_TEMPLATE #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2023
Merged

add PULL_REQUEST_TEMPLATE #688

merged 1 commit into from
Jun 22, 2023

Conversation

davidhewitt
Copy link
Contributor

@davidhewitt davidhewitt commented Jun 22, 2023 •
edited by pydantic-hooky bot
Loading

Adds a PR template with a few helpful checklist items. Copied and modified from main pydantic repo.

Selected Reviewer: @samuelcolvin

@davidhewitt
Copy link
Contributor Author

please review

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 22, 2023

CodSpeed Performance Report

Merging #688 dh/pr-template (8f96c02) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 125 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

@davidhewitt davidhewitt merged commit 875befe into main Jun 22, 2023
@davidhewitt davidhewitt deleted the dh/pr-template branch June 22, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriangb adriangb adriangb approved these changes

Assignees

@samuelcolvin samuelcolvin

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidhewitt @adriangb @samuelcolvin