Skip to content

debug codspeed build on main #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

debug codspeed build on main #707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43639be
debug codspeed build on main
davidhewitt Jun 28, 2023
c86b615
try shuffling default features around
davidhewitt Jun 28, 2023
f91a44c
build just cdlyib crate
davidhewitt Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/codspeed.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,9 @@ jobs:
- name: Install pydantic-core
# build-prod does not include MiMalloc because it bypasses Maturin
run: |
pip install -e .
pip install -e . --config-settings=build-args='--verbose' -v
make build-prod
python -c 'import pydantic_core'
python -c 'import pydantic_core; print(pydantic_core._pydantic_core)'
env:
CONST_RANDOM_SEED: 0 # Fix the compile time RNG seed

Expand Down
4 changes: 2 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ include = [
]

[dependencies]
pyo3 = "0.19.0"
pyo3 = { version = "0.19.0", features = ["generate-import-lib", "num-bigint"] }
regex = "1.6.0"
strum = { version = "0.25.0", features = ["derive"] }
strum_macros = "0.24.3"
Expand All @@ -53,7 +53,7 @@ extension-module = ["pyo3/extension-module"]
auto-initialize = ["pyo3/auto-initialize"]
# disabled for benchmarks since it makes microbenchmark performance more flakey
mimalloc-allocator = ["mimalloc", "mimalloc/local_dynamic_tls"]
default = ["pyo3/generate-import-lib", "pyo3/num-bigint"]
default = []

[profile.release]
lto = "fat"
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ build-dev:
.PHONY: build-prod
build-prod:
@rm -f pydantic_core/*.so
cargo build --release --features extension-module
cargo rustc --release --no-default-features --features extension-module --verbose --crate-type=cdylib
@rm -f target/release/lib_pydantic_core.d
@rm -f target/release/lib_pydantic_core.rlib
@mv target/release/lib_pydantic_core.* pydantic_core/_pydantic_core.so
Expand Down