-
Notifications
You must be signed in to change notification settings - Fork 292
Type validation context as dict[str, Any] | None
#709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
please review |
CodSpeed Performance ReportMerging #709 will improve performances by 10.16%Comparing Summary
Benchmarks breakdown
|
d5c5202
to
4d2e4a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
humm, but I thought you could pass whatever you like to context
?
I think you technically can, but it is typed as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no objections to this change, but defer to @samuelcolvin if he wants to keep it as an Any
. In practice I think this is probably helpful for making sure that different libraries/etc. are forced to play a bit more nicely with each other if they make use of the functionality.
okay, fine by me. linting is failing, also conflicts, please update. |
4d2e4a7
to
70dd797
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #709 +/- ##
==========================================
+ Coverage 93.66% 93.73% +0.07%
==========================================
Files 99 99
Lines 14247 13807 -440
Branches 25 25
==========================================
- Hits 13344 12942 -402
+ Misses 897 859 -38
Partials 6 6
... and 41 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Selected Reviewer: @dmontagu