-
Notifications
You must be signed in to change notification settings - Fork 291
basic tidy-ups to core_schema.py #713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
basic tidy-ups to core_schema.py #713
Conversation
please review |
CodSpeed Performance ReportMerging #713 Summary
Benchmarks breakdown
|
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #713 +/- ##
=======================================
Coverage 93.71% 93.71%
=======================================
Files 99 99
Lines 13838 13838
Branches 25 25
=======================================
Hits 12968 12968
Misses 864 864
Partials 6 6
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (not sure if you want to work on this more, so leaving open)
FWIW, I'm happy with the order of things here, although somewhat subjective I think it makes sense. that said, I'd be happy to consider moving groups of methods into separate files.
I will merge this now and then consider the grouping as a possible follow-up. |
Change Summary
This is a very basic first pass at improving the documentation for
core_schema.py
.There's a lot of members and they're poorly grouped. I started playing around with sort order but it created a lot of pain in a big diff, so I backed out for now. I think I might experiment in a future PR with grouping into submodules which can then have better meaningful grouping.
Related issue number
N/A
Checklist
pydantic-core
(except for expected changes)Selected Reviewer: @samuelcolvin