Skip to content

Make __pydantic_extra__ = None when extra='forbid' #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2023
Merged

Conversation

dmontagu
Copy link
Collaborator

@dmontagu dmontagu commented Jul 1, 2023

This resolves pydantic/pydantic#6332

Here's the pydantic PR adding the relevant test: pydantic/pydantic#6341

@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Merging #725 (3473a92) into main (7da65c4) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #725   +/-   ##
=======================================
  Coverage   93.63%   93.63%           
=======================================
  Files          99       99           
  Lines       13911    13911           
  Branches       25       25           
=======================================
  Hits        13026    13026           
  Misses        879      879           
  Partials        6        6           
Impacted Files Coverage Δ
src/validators/model_fields.rs 98.31% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7da65c4...3473a92. Read the comment docs.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 1, 2023

CodSpeed Performance Report

Merging #725 will not alter performances

Comparing pydantic-6332 (3473a92) with main (7da65c4)

Summary

✅ 125 untouched benchmarks

@adriangb adriangb merged commit 3796409 into main Jul 2, 2023
@adriangb adriangb deleted the pydantic-6332 branch July 2, 2023 17:55
@jessekrubin
Copy link

Oh this is the weird error I was getting!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.model_extra is non-None with extra="forbid"
4 participants