Skip to content

Add benchmark for field validator functions #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

adriangb
Copy link
Member

@adriangb adriangb commented Jul 1, 2023

Selected Reviewer: @samuelcolvin

@adriangb
Copy link
Member Author

adriangb commented Jul 1, 2023

please review

@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Merging #726 (9eef7c7) into main (0d12efd) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #726   +/-   ##
=======================================
  Coverage   93.63%   93.63%           
=======================================
  Files          99       99           
  Lines       13911    13911           
  Branches       25       25           
=======================================
  Hits        13026    13026           
  Misses        879      879           
  Partials        6        6           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d12efd...9eef7c7. Read the comment docs.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 1, 2023

CodSpeed Performance Report

Merging #726 will not alter performances

Comparing field-validator-bench (9eef7c7) with main (0d12efd)

Summary

✅ 125 untouched benchmarks

🆕 1 new benchmarks

Benchmarks breakdown

Benchmark main field-validator-bench Change
🆕 test_field_function_validator N/A 941.3 µs N/A

@samuelcolvin samuelcolvin merged commit a63621a into main Jul 3, 2023
@samuelcolvin samuelcolvin deleted the field-validator-bench branch July 3, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants