fix segfaults on tests in debug builds for PyPy #744
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This PR unifies the recursion guard limit between serialization and validation to 255 (thanks @adamreichold for the suggestion to move to a single limit).
I also add
pytest.skip
to a few tests which fail on PyPy with debug builds. This is because Rust debug builds don't optimize their stack space, so we hit trivial stack overflows.Finally I add a
test-debug
job for PyPy 3.9 - can bump to PyPy 3.10 once the upstream PyO3 bug is fixed.Related issue number
Ref #659
This should avoid crashes on debug builds with PyPy. (Doesn't close the full issue, which also exposes a bug in PyO3.)
Checklist
pydantic-core
(except for expected changes)