-
Notifications
You must be signed in to change notification settings - Fork 292
Properly truncate characters when splitting up strings in error repr #746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
please review |
Best not to rely on nightly features now we're in production :) The implementations of |
Yep, that’s what I was thinking of doing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #746 +/- ##
=======================================
Coverage 93.63% 93.63%
=======================================
Files 99 99
Lines 13895 13917 +22
Branches 25 25
=======================================
+ Hits 13010 13031 +21
- Misses 879 880 +1
Partials 6 6
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
CodSpeed Performance ReportMerging #746 will improve performances by 10.83%Comparing Summary
Benchmarks breakdown
|
@davidhewitt mind taking a stab at a review since we already discussed this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Fixes pydantic/pydantic#6448
Selected Reviewer: @dmontagu