Skip to content

add build_info to _pydantic_core #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2023
Merged

add build_info to _pydantic_core #749

merged 2 commits into from
Jul 9, 2023

Conversation

samuelcolvin
Copy link
Member

@samuelcolvin samuelcolvin commented Jul 7, 2023

Useful to check if PGO was used. We should add this to pydantic.version.version_info().

Selected Reviewer: @davidhewitt

@samuelcolvin
Copy link
Member Author

please review.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 7, 2023

CodSpeed Performance Report

Merging #749 will not alter performances

Comparing pgo-build-info (0516bf1) with main (fac2a40)

Summary

✅ 126 untouched benchmarks

Copy link
Member

@adriangb adriangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I assume you tested the actual contents locally and they look good?

@samuelcolvin
Copy link
Member Author

Looks good! I assume you tested the actual contents locally and they look good?

It should say 'release pgo mimalloc' in production with PGO. I'll add the negative cases like no-pgo and std-allocator.

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #749 (4709c78) into main (fac2a40) will decrease coverage by 0.01%.
The diff coverage is 80.00%.

❗ Current head 4709c78 differs from pull request most recent head 0516bf1. Consider uploading reports for the commit 0516bf1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #749      +/-   ##
==========================================
- Coverage   93.64%   93.63%   -0.01%     
==========================================
  Files          99       99              
  Lines       13929    13939      +10     
  Branches       25       25              
==========================================
+ Hits        13044    13052       +8     
- Misses        879      881       +2     
  Partials        6        6              
Impacted Files Coverage Δ
src/lib.rs 95.55% <80.00%> (-4.45%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fac2a40...0516bf1. Read the comment docs.

Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like helpful metadata for us to know when debugging odd errors if we add to version info as you suggest, and also for users to verify if they're getting the "most optimized" build.

@samuelcolvin samuelcolvin merged commit 0b31711 into main Jul 9, 2023
@samuelcolvin samuelcolvin deleted the pgo-build-info branch July 9, 2023 05:10
adriangb pushed a commit that referenced this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants