-
Notifications
You must be signed in to change notification settings - Fork 293
add build_info
to _pydantic_core
#749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
please review. |
CodSpeed Performance ReportMerging #749 will not alter performancesComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I assume you tested the actual contents locally and they look good?
It should say |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #749 +/- ##
==========================================
- Coverage 93.64% 93.63% -0.01%
==========================================
Files 99 99
Lines 13929 13939 +10
Branches 25 25
==========================================
+ Hits 13044 13052 +8
- Misses 879 881 +2
Partials 6 6
Continue to review full report in Codecov by Sentry.
|
4709c78
to
0516bf1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like helpful metadata for us to know when debugging odd errors if we add to version info as you suggest, and also for users to verify if they're getting the "most optimized" build.
Useful to check if
PGO
was used. We should add this topydantic.version.version_info()
.Selected Reviewer: @davidhewitt