Update speedate to 0.11.0 #769
Conversation
| tz_offset: None, | ||
| tz_offset: dt.time.tz_offset, |
There was a problem hiding this comment.
@samuelcolvin what are your thoughts on this? It means that we allow datetime(2023, 7, 13, 0, 0, 0, tzinfo=timezone.utc) -> date(2023, 7, 13). We need it because when we parse a unix timestamp to a date it goes through a datetime first. I can try to work around it but maybe it's reasonable as is.
There was a problem hiding this comment.
I think it seems fine.
Simpler might be to just do dt.time.hour == 0 && ... && dt.time.microsecond == 0?
|
please review |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #769 +/- ##
=======================================
Coverage 93.66% 93.66%
=======================================
Files 99 99
Lines 14247 14264 +17
Branches 25 25
=======================================
+ Hits 13344 13361 +17
Misses 897 897
Partials 6 6
Continue to review full report in Codecov by Sentry.
|
CodSpeed Performance ReportMerging #769 will not alter performanceComparing Summary
|
| tz_offset: None, | ||
| tz_offset: dt.time.tz_offset, |
There was a problem hiding this comment.
I think it seems fine.
Simpler might be to just do dt.time.hour == 0 && ... && dt.time.microsecond == 0?
Selected Reviewer: @davidhewitt