Skip to content

Fix scientific floats with uppercase E #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2023
Merged

Conversation

kzrnm
Copy link
Contributor

@kzrnm kzrnm commented Jul 15, 2023

Change Summary

#774 fixed parsing of scientific-notation floats with lowercase e, but not with uppercase E.

Related issue number

#774

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@dmontagu @adriangb please review

@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Merging #779 (6de2440) into main (3597351) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #779   +/-   ##
=======================================
  Coverage   93.67%   93.67%           
=======================================
  Files          99       99           
  Lines       14290    14290           
  Branches       25       25           
=======================================
  Hits        13386    13386           
  Misses        898      898           
  Partials        6        6           
Impacted Files Coverage Δ
src/input/parse_json.rs 96.34% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3597351...6de2440. Read the comment docs.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 15, 2023

CodSpeed Performance Report

Merging #779 will improve performances by 11.38%

Comparing kzrnm:fix/float (6de2440) with main (3597351)

Summary

🔥 1 improvements
✅ 125 untouched benchmarks

Benchmarks breakdown

Benchmark main kzrnm:fix/float Change
🔥 test_set_of_ints_core_json_duplicates 5.4 ms 4.9 ms +11.38%

@adriangb adriangb merged commit 9be711e into pydantic:main Jul 15, 2023
@adriangb
Copy link
Member

Thanks!

@kzrnm kzrnm deleted the fix/float branch July 15, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants