Skip to content

fix type annotations for Url & MultiHostUrl build #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

davidhewitt
Copy link
Contributor

@davidhewitt davidhewitt commented Jul 17, 2023

Change Summary

These methods have an incorrect type annotation - they return instances of Url and MultiHostUrl.

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @samuelcolvin

@davidhewitt
Copy link
Contributor Author

please review

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@e3ceb4b). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #781   +/-   ##
=======================================
  Coverage        ?   93.67%           
=======================================
  Files           ?       99           
  Lines           ?    14290           
  Branches        ?       25           
=======================================
  Hits            ?    13386           
  Misses          ?      898           
  Partials        ?        6           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3ceb4b...bf3c0de. Read the comment docs.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 17, 2023

CodSpeed Performance Report

Merging #781 will not alter performance

Comparing dh/fix-url-build-annotation (bf3c0de) with main (e3ceb4b)

Summary

✅ 126 untouched benchmarks

@davidhewitt davidhewitt force-pushed the dh/fix-url-build-annotation branch from dd911ce to bf3c0de Compare July 17, 2023 10:23
@davidhewitt davidhewitt merged commit ff660dc into main Jul 17, 2023
@davidhewitt davidhewitt deleted the dh/fix-url-build-annotation branch July 17, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants