Skip to content

set up stable Rust toolchain on all rust builds #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Conversation

davidhewitt
Copy link
Contributor

@davidhewitt davidhewitt commented Jul 17, 2023

Change Summary

Should fix the build failures observed in CI related to the recently-stabilized OnceLock.

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @adriangb

@davidhewitt
Copy link
Contributor Author

please review

Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidhewitt davidhewitt enabled auto-merge (squash) July 17, 2023 10:14
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #782 (ce66bb1) into main (9be711e) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #782   +/-   ##
=======================================
  Coverage   93.67%   93.67%           
=======================================
  Files          99       99           
  Lines       14290    14290           
  Branches       25       25           
=======================================
  Hits        13386    13386           
  Misses        898      898           
  Partials        6        6           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9be711e...ce66bb1. Read the comment docs.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 17, 2023

CodSpeed Performance Report

Merging #782 will not alter performance

Comparing dh/fix-ci (ce66bb1) with main (9be711e)

Summary

✅ 126 untouched benchmarks

@davidhewitt davidhewitt merged commit e3ceb4b into main Jul 17, 2023
@davidhewitt davidhewitt deleted the dh/fix-ci branch July 17, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants