Special case bool literals #784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #784 will improve performances by 10.38%Comparing Summary
Benchmarks breakdown
|
davidhewitt
reviewed
Jul 17, 2023
Comment on lines
+51
to
+57
| if let Ok(bool) = k.strict_bool() { | ||
| if bool { | ||
| expected_bool.true_id = Some(id); | ||
| } else { | ||
| expected_bool.false_id = Some(id); | ||
| } | ||
| } |
There was a problem hiding this comment.
The chain of if let Ok(...) = input.x() here just seems to scream at me for the input-as-enum we spoke about the other day...
|
I guess so. I don't trust our benchmarks because of all of the noise going on, but this is the one I would expect to get slower, so maybe it's real. Nonetheless, I'm surprised it's slower at all. That benchmark should just consist of checking a |
|
Case in point: another benchmark shows a larger improvement than the literal benchmark shows a regression, which is indicates to me there’s a lot of noise |
davidhewitt
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did this while working on #783 but it's not needed there. Posting it here in case we think it's worth it. @davidhewitt can you take a look and close if you think it's not worth it or too far from what you'd implement?