Remove patch version number from error link #794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #794 will degrade performances by 11.3%Comparing Summary
Benchmarks breakdown
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #794 +/- ##
==========================================
- Coverage 93.53% 93.52% -0.01%
==========================================
Files 100 100
Lines 14376 14379 +3
Branches 25 25
==========================================
+ Hits 13446 13448 +2
- Misses 924 925 +1
Partials 6 6
Continue to review full report in Codecov by Sentry.
|
hramezani
force-pushed
the
error_link
branch
2 times, most recently
from
66ea0fc to
e9f230c
Compare
|
please review |
samuelcolvin
requested changes
Jul 21, 2023
src/errors/validation_exception.rs
Outdated
| get_pydantic_version(py).unwrap_or("latest") | ||
| ) | ||
| })) | ||
| let pydantic_version = match get_pydantic_version(py) { |
There was a problem hiding this comment.
we need to do this inside the get_or_init to avoid the overhead of calling this each time, best to create a new function including this logic and the format!
|
please review |
samuelcolvin
approved these changes
Jul 21, 2023
|
thanks so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes pydantic/pydantic#6521
Selected Reviewer: @davidhewitt