Skip to content

TST: Make tests work on python 2.6 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2015

Conversation

davidastephens
Copy link
Member

Fixes #9

davidastephens added a commit that referenced this pull request Jan 22, 2015
TST: Make tests work on python 2.6
@davidastephens davidastephens merged commit caeff17 into pydata:master Jan 22, 2015
@hayd
Copy link
Member

hayd commented Jan 22, 2015

Thanks for fixing that, my bad for leaving that in a bad state. Sorry!

@hayd
Copy link
Member

hayd commented Jan 22, 2015

(I was surprised that the pandas tests no longer have self.assertIsInstance this used to be overridden in pandas.util.testing which was useful for 2.6 - ... The other option here is to use unittest2 in python 2.6 - I wonder if pandas should do this or should extract out pandas_testing)

I had previously located the PR, where this was removed/made tm.assertIsInstance so it's no longer same API across pandas versions :(, can't find it atm.

@davidastephens
Copy link
Member Author

No prob. I was the one that wrote those incompatible tests in pandas..

@davidastephens davidastephens deleted the issue9 branch March 25, 2015 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST: make sure tests work on python 2.6
2 participants