Fixed two dividend related issues #602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add relevant tests for this issue? Thanks! |
|
Thanks for the reply. Those two are bug fixes and are covered already by the existing test cases. I could think about adding one or more if needed.
Happy New Year!
-Peiji
On Monday, December 31, 2018, 6:19:05 AM PST, Addison Lynch <[email protected]> wrote:
Can you please add relevant tests for this issue? Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
added one test case for symbol NTR. It was failed before with divided by zero error. |
|
Happy New Year to you too!
Peiji
On Monday, December 31, 2018, 11:23:24 AM PST, Addison Lynch <[email protected]> wrote:
@peijiche perfect...I should have been more specific, but that's exactly what I was referring to. Thank you and happy new year!
cc @bashtage
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Issue 1: DataReader(symbol, 'yahoo-dividends', start, end) will have divided by zero error for some dividend stocks like "NTR".
Root cause: when the stock has event like "1/0 Stock Split", it will fail.
The fix: do numerator check first before evaluating the split ratio. In the above case, it should be Splitratio=1
-Issue 2: fixed a bug that failed dividend/split test case of "def test_yahoo_DataReader(self)" in tests/test_yahoo.py.