Skip to content

Fixed environment variable name #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2019
Merged

Conversation

oceanapplications
Copy link
Contributor

No description provided.

@addisonlynch
Copy link
Contributor

Probably should have stuck with the previous naming convention using _API_KEY as the suffix. @bashtage will likely decide if this should change given that the current convention is now merged into dev but has not been released. Either IEX_API_TOKEN or IEX_API_KEY works regardless.

However, use of this package does not require the publishable token and the value does not need to be set for the documentation, as a key will be added to the travis environment, in which the documentation is built by doctr.

Thanks!

@bashtage
Copy link
Contributor

Could you fix it in what's new as well?

@bashtage
Copy link
Contributor

Thanks.

@bashtage bashtage merged commit 88363ea into pydata:master Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants