Limit data use #649
Merged
Limit data use #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the minimum requested data is a full year. This limits the request to more specific time frames. The current functionality is undesirable because IEX is no longer unlimited. After this change, for less than 6 days, the cost is 50 messages. Before it was over 3,000.
|
@bashtage ready |
|
Needs a test. |
|
Hard to test this because the method is private and end results are the same (only effect is message weighting behind the scenes) |
|
It is fine to directly test private functions internally. Private doesn't mean private to pdr, only the everything else. |
|
In particular all of the new paths need to be visited. |
|
Need to get some coverage reporter attached |
|
Can add coverage to CI |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the minimum requested data is a full year. This limits the request to more specific time frames.
The current functionality is undesirable because IEX is no longer unlimited. After this change, for less than 6 days, the cost is 50 messages. Before it was over 3,000.