Skip to content

COMPAT: Repair PY2 issues #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 29, 2019
Merged

COMPAT: Repair PY2 issues #664

merged 3 commits into from
Aug 29, 2019

Conversation

addisonlynch
Copy link
Contributor

@addisonlynch addisonlynch commented Aug 27, 2019

Merging 0.7.4 py2 compat changes into master in prep for 0.8.0

Remvoe dep on pandas.compat for 0.7.2 release
Restore Python 2.7 for 0.7 branch
@bashtage
Copy link
Contributor

The important question is whether pdr should be Python 3 only for 0.8 on, in which case all of the PY2/3 compat code can be removed

@addisonlynch
Copy link
Contributor Author

addisonlynch commented Aug 27, 2019

I think that Python 3 only would be sensible given that this package spun out of pandas, which ended py2 support. I dont think the 10-15% of pdr userbase which is 2.6/7 warrants keeping it around long enough, and even if so, for how long should it last?

image

@bashtage
Copy link
Contributor

Either 0.8 is the last PY2 compat release of 0.7 is the last PY2 release. If it is the latter, then we can remove all PY2/3 code now.

@addisonlynch
Copy link
Contributor Author

Maybe keep for 0.8, end in 0.9...thinking it could be a little quick to cut it out (without prior notification) if 0.8 is released soon. We already have the code here, so not much work to keep it around.

@addisonlynch
Copy link
Contributor Author

Looks like one pd.compat.binary_type was missed in moex.py. Added that fix here as well. This will now close #665

@bashtage bashtage merged commit 9f56093 into pydata:master Aug 29, 2019
@bashtage
Copy link
Contributor

Need to add 3.7 for testing and get tests/xfail before release.

@gliptak
Copy link
Contributor

gliptak commented Sep 18, 2019

With build green, could 0.8.0pre be tagged?

@bashtage
Copy link
Contributor

I think docs need to be updated before the tag, but close.

@bashtage
Copy link
Contributor

FWIW current master is now correctly tagged 0.8.0dev0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not working with new pandas versions
3 participants