Fixing tests for index.freq #814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #814 +/- ##
===========================================
- Coverage 84.31% 73.87% -10.45%
===========================================
Files 62 62
Lines 2837 2840 +3
Branches 303 303
===========================================
- Hits 2392 2098 -294
- Misses 371 663 +292
- Partials 74 79 +5
Continue to review full report at Codecov.
|
|
Looks good to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing tests.
pandas.testing.assert_series_equal now includes a default argument of check_freq=True. With this new arg some of the tests are failing as the index.freq does not match in comparisons.
I've adjusted index.freq so that the tests pass. Another option is to use check_freq=False, but this argument is not available in earlier versions of pandas. Alternatively, we could inspect the function for the existence of check_freq and pass False if required. I considered changing index.freq to be the easiest option.
Thanks