Skip to content

Adding yahoo finance documentation #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 2, 2020
Merged

Conversation

lukashalim
Copy link
Contributor

@lukashalim lukashalim commented Sep 1, 2020

  • closes Simple question about documentation #817
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • passes black --check pandas_datareader
  • added entry to docs/source/whatsnew/vLATEST.txt

Added yahoo finance documentation in response to pydata#817
fix: corrected mistaken change to date
fix: removed extra files
fix: Restoring changed files to master
@lukashalim
Copy link
Contributor Author

I think this version is better.
I renamed v0.9.1.txt because the file name had an "." in the wrong place, which was causing an error when I tried to build the documentation.

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2020

Codecov Report

Merging #823 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #823      +/-   ##
==========================================
- Coverage   64.67%   64.64%   -0.04%     
==========================================
  Files          62       62              
  Lines        2848     2848              
  Branches      305      305              
==========================================
- Hits         1842     1841       -1     
- Misses        932      933       +1     
  Partials       74       74              
Impacted Files Coverage Δ
pandas_datareader/tests/test_moex.py 73.91% <0.00%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2ef4e6...04c7209. Read the comment docs.

@bashtage
Copy link
Contributor

bashtage commented Sep 1, 2020

Can you unstage the sqllite file. This should not be added.

@bashtage
Copy link
Contributor

bashtage commented Sep 1, 2020

After that it should be good. The rename is fine with me.

@lukashalim
Copy link
Contributor Author

I'm unfortunately stuck on unstaging the file.

@lukashalim
Copy link
Contributor Author

lukashalim commented Sep 2, 2020

Okay, I think I finally have it - I just went to my fork, deleted cache.sqlite, and committed

@bashtage
Copy link
Contributor

bashtage commented Sep 2, 2020

LGTM.

@bashtage bashtage merged commit adb67b2 into pydata:master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simple question about documentation
3 participants