Skip to content

use ISheetWriter interface #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2020
Merged

use ISheetWriter interface #37

merged 1 commit into from
Oct 2, 2020

Conversation

chfw
Copy link
Member

@chfw chfw commented Oct 1, 2020

With your PR, here is a check list:

  • Has test cases written?
  • Has all code lines tested?
  • Has make format been run?
  • Please update CHANGELOG.yml(not CHANGELOG.rst)
  • Passes all Travis CI builds
  • Has fair amount of documentation if your change is complex
  • Agree on NEW BSD License for your contribution

@codecov-commenter
Copy link

Codecov Report

Merging #37 into dev will decrease coverage by 0.12%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #37      +/-   ##
==========================================
- Coverage   98.54%   98.41%   -0.13%     
==========================================
  Files          13       13              
  Lines         688      695       +7     
==========================================
+ Hits          678      684       +6     
- Misses         10       11       +1     
Impacted Files Coverage Δ
pyexcel_xls/xlsw.py 98.21% <92.85%> (-1.79%) ⬇️
pyexcel_xls/xlsr.py 99.25% <100.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3b57b4...1a3b1e9. Read the comment docs.

@chfw chfw merged commit 0c1dea4 into dev Oct 2, 2020
@chfw chfw deleted the update-writer-interface branch October 2, 2020 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants