-
-
Notifications
You must be signed in to change notification settings - Fork 21
Update xlsw.py: fix timedelta support #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix timedelta support
W291 trailing whitespace: fixed
Bad cell ref [0, 2] -> [0, 3]
Codecov Report
@@ Coverage Diff @@
## dev #49 +/- ##
==========================================
+ Coverage 97.42% 98.42% +1.00%
==========================================
Files 13 13
Lines 698 697 -1
==========================================
+ Hits 680 686 +6
+ Misses 18 11 -7
Continue to review full report at Codecov.
|
I am happy that you fix the problem. But does it make sense to support timedelta? So can you describe your use case? |
I write a python program that must export ical events to a spreadsheet. Currently, with pyexcel module:
|
I see. But xlrd returns date time for timedelta. How do you translate it back to date time? |
Yes, this is an issue Is it worth it? maybe you are right. After all, xls format is less and less used. |
Xls has a limit on the number of rows so it is better to avoid using xls. UK’s national health service used xls format to persist collected reported COVID cases in 2020 and got a mystery problem: where did the data go? Oh well, xls skipped excessive rows. |
I think we can release the change but note it in doc. Of course, If you are able to work out the remedying solution, and it can be added to the doc. |
By 'the doc', do you mean 'README.rst'? |
fix timedelta support
With your PR, here is a check list:
make format
been run?