Skip to content

Allow xlwt on Python 2 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 10, 2016
Merged

Allow xlwt on Python 2 #5

merged 2 commits into from
May 10, 2016

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented May 10, 2016

No description provided.

@codecov-io
Copy link

codecov-io commented May 10, 2016

Current coverage is 99.07%

Merging #5 into master will not change coverage

@@             master         #5   diff @@
==========================================
  Files             9          9          
  Lines           536        536          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            531        531          
  Misses            5          5          
  Partials          0          0          

Powered by Codecov. Last updated by e450170...e78ac3c

@jayvdb
Copy link
Contributor Author

jayvdb commented May 10, 2016

Ugh, do not merge. It will break pyexcel builds
https://travis-ci.org/jayvdb/pyexcel/jobs/129033251

@jayvdb jayvdb force-pushed the use-sid branch 2 times, most recently from 5964492 to e191abd Compare May 10, 2016 06:48
@jayvdb
Copy link
Contributor Author

jayvdb commented May 10, 2016

The earlier problem is now fixed, due to pyexcel/pyexcel-mobans#7

However there is another problem can be seen on rnd_requirements.txt of pyexcel/pyexcel#42 . I suspect it is a another bug in pip/setuptools, regarding how it handles .zip, but possibly also git+https:// and other formats.
Without those manually listed dependencies, the build looks like:
https://travis-ci.org/jayvdb/pyexcel/builds/129056716

I have a few ideas, but have run out of time to investigate further.

@jayvdb
Copy link
Contributor Author

jayvdb commented May 10, 2016

still dont pull! I suspect that pyexcel/pyexcel-mobans#7 isnt correct. still playing.. ;-)

jayvdb added 2 commits May 10, 2016 16:30
Use xlwt-future only on Python 3
@jayvdb
Copy link
Contributor Author

jayvdb commented May 10, 2016

ok, should be good to go. pyexcel/pyexcel-mobans#9 was part of the problem, and the other problem was using pip/setuptools installing via vcs/source instead of via wheel.
pyexcel/pyexcel#42 shows it working even as a zip, with upgraded setuptools/pip (offtopic , I've been seeing that pypy core dump a bit lately ..)

@chfw chfw merged commit ba48e6f into pyexcel:master May 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants