[WIP] refactor: enhance DebPackages and DebPackage facts to include detailed package information #1337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wowi42
commented
Apr 11, 2025
wowi42
commented
- Updated the DebPackages class to return a structured dictionary for each package, including desired action, status, version, architecture, and description.
- Modified the regex pattern to capture additional package details.
- Adjusted related test cases to reflect the new data structure for package facts.
…d package information - Updated the DebPackages class to return a structured dictionary for each package, including desired action, status, version, architecture, and description. - Modified the regex pattern to capture additional package details. - Adjusted related test cases to reflect the new data structure for package facts.
Fizzadar
reviewed
May 13, 2025
There was a problem hiding this comment.
@wowi42 this is neat, way more info than before, but does introduce a breaking change (I believe it'll also break apt.packages).
It might be better off to expand the DebPackage fact rather than this one - is there a use-case in mind for getting all this info for all packages vs. individual packages?
vram0gh2
added a commit
to vram0gh2/pyinfra
that referenced
this pull request
Jun 1, 2025
Fixes pyinfra-dev#1337 which occurs due a type mismatch between the local file mode returned by get_path_permissions_mode() in api/util.py (str), and the mode data type from the remote file fact (int). Make the change in api/util.py to return an int so the behavior both matches the function's docstring and the implied semantics within put() in operations/files.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.