Skip to content

Add podman connector #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: 3.x
Choose a base branch
from

Conversation

Griffoen
Copy link
Contributor

@Griffoen Griffoen commented May 4, 2025

The Podman CLI is compatible with the Docker CLI, so I refactored the docker connector to create the Podman connector.
This enables users of distros which prefer Podman over Docker to test their deployments more easily.

The Podman connector works exactly like the docker connector, for example: pyinfra @podman/fedora:42 dnf packages=uv

I copied the docker tests in /tests/test_connectors/test_docker.py for the Podman tests.
However, I omitted the /test/end-to-end/test_e2e_docker.py tests since I don't know how they are supposed to be set up, and I don't have docker installed to run the tests.

@Griffoen
Copy link
Contributor Author

Griffoen commented May 4, 2025

The failing test (below) has nothing to do with this MR, and it succeeded after a re-run while developing this MR.
I don't know what is going on here, but it does not affect this MR as far as I can tell.

=========================== short test summary info ============================
FAILED tests/test_connectors/test_ssh.py::TestSSHConnector::test_get_file_sudo - AssertionError: expected call not found.
Expected: getfo('/tmp/pyinfra-e9c0d3c8ffca943daa0e75511b0a09c84b59c508', <MagicMock name='open()' id='139776354182096'>)
  Actual: not called.
========== 1 failed, 1169 passed, 12 deselected, 1 warning in 22.55s ===========

@Fizzadar Fizzadar force-pushed the Add-podman-connector branch from b024498 to 1fa622e Compare May 13, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants