-
-
Notifications
You must be signed in to change notification settings - Fork 273
Out-of-sample predictions for BART intro notebook #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Thanks! What about adding a first OOS example where you treat the problem as a regression and then a second one (the one you already wrote) showing that BART is not good at extrapolation? |
Sure! I will add the OOS part to the first example as well. Should I keep the bikes example as it is? |
I would not change what you already added. What I would add is an example of out-of-sample predictions using the bike dataset, with the only difference being that we treat it as a regression problem, not a time-series problem. We can keep the coal mining example unmodified. |
I added a regression-like example in ae24deb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic! Thanks!
@juanitorduz just for completeness, you have added significant piece of new code, so you should add yourself to both the authors section at the bottom (like you did) and at the |
Out-of-sample predictions for BART intro notebook
Closes pymc-devs/pymc-bart#48
bikes
example.