Skip to content

Add deserialize module #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jun 3, 2025
Merged

Add deserialize module #489

merged 20 commits into from
Jun 3, 2025

Conversation

williambdean
Copy link
Collaborator

@williambdean williambdean commented May 29, 2025

Will rebase one #470 is merged

@williambdean williambdean marked this pull request as draft May 29, 2025 14:12
@williambdean williambdean changed the title Add deserialize functionality back in Add deserialize module May 29, 2025
@zaxtax
Copy link
Contributor

zaxtax commented May 29, 2025

Ok #470 is merged so I think after this is rebased and passes CI, we can merge it too

@williambdean williambdean marked this pull request as ready for review June 1, 2025 17:26
@williambdean
Copy link
Collaborator Author

Seem like unrelated fails...

@zaxtax
Copy link
Contributor

zaxtax commented Jun 3, 2025 via email

@zaxtax zaxtax self-requested a review June 3, 2025 11:49
Copy link
Contributor

@zaxtax zaxtax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Once this passes CI we can merge it in

@williambdean
Copy link
Collaborator Author

Thanks @zaxtax for the review!

@zaxtax
Copy link
Contributor

zaxtax commented Jun 3, 2025 via email

@williambdean
Copy link
Collaborator Author

Done!

@zaxtax zaxtax merged commit da04a98 into pymc-devs:main Jun 3, 2025
17 checks passed
@williambdean williambdean deleted the add-deserialize branch June 3, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants