Update pmf-pymc example #1447
Merged
Update pmf-pymc example #1447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, I think this is reasonable and most important of all, gets the example to run again. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mentioned some of the choices here in #830:
-- Jokes are in a small json file
-- Print statements are now python2/3 compatible
-- The
PMFclass does some cacheing, which I left in, but I moved all example data into its own folder, and removed the cached files from the repo (since it can be built locally).-- Reduced the number of steps in the mcmc sampling from 5000 to 300, since it was going super slow.