Skip to content

Tweaks to API quickstart notebook #2193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2017
Merged

Tweaks to API quickstart notebook #2193

merged 1 commit into from
May 18, 2017

Conversation

fonnesbeck
Copy link
Member

In particular, applied usage of fit function instead of method.

@springcoil springcoil merged commit 6c31539 into master May 18, 2017
@twiecki twiecki deleted the api_notebook_update branch May 18, 2017 08:38
@twiecki
Copy link
Member

twiecki commented May 18, 2017

Note that this is equivalent to calling pm.fit(method='fullrank_advi'). This statement should be removed then, there is also one above about the object-oriented framework behind pm.fit. I actually kinda liked the introduction of the OO framework.

@fonnesbeck fonnesbeck mentioned this pull request May 18, 2017
Merged
@fonnesbeck
Copy link
Member Author

Ah, you're right. I dropped an example of the OO interface back in with the PR above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fonnesbeck @twiecki @springcoil