fixes in smc backend refactoring, added test #2286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColCarroll
reviewed
Jun 8, 2017
| @@ -13,15 +14,13 @@ | |||
| @pytest.mark.xfail(condition=(theano.config.floatX == "float32"), reason="Fails on float32") | |||
| class TestSMC(SeededTest): | |||
|
|
|||
| def setup_method(self): | |||
| super(TestSMC, self).setup_method() | |||
| def setup_class(self): | |||
There was a problem hiding this comment.
just want to make sure this is intentional -- you'll now reuse the same test folder for every test in the class
There was a problem hiding this comment.
ah good point! will fix that!
edit: no fix needed, as we set the rm_flag=True it removes the previous results
| with open(self.atmip_path(prev), 'rb') as buff: | ||
| return pickle.load(buff) | ||
|
|
||
| with model: |
There was a problem hiding this comment.
I like that this nesting is explicit, but just for interest's sake:
starting with python 2.7 you can use multiple context managers in one line
with open(...) as buff, model:
step = pickle.load(buff)
There was a problem hiding this comment.
cool! didnt know that! but here I think it is indeed better to have them nested for clarity
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to refactoring from @ColCarrol , added test that tests stage_handler features.