-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[MRG] DOC: Fix the space between attributes in docs #3822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3822 +/- ##
==========================================
- Coverage 90.77% 90.76% -0.01%
==========================================
Files 133 133
Lines 20566 20566
==========================================
- Hits 18669 18667 -2
- Misses 1897 1899 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for doing this. This has been on my to do list for ages.
You are welcome @rpgoldman :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice. couldn't believe a "simple shell script" wouldn't hit more false positives.
|
||
|
||
def close_to_logical(x, v, bound, name="value"): | ||
assert np.all(np.logical_or( | ||
np.abs(np.bitwise_xor(x, v)) < bound, | ||
x == v)), name + " out of bounds : " + repr(x) + ", " + repr(v) + ", " + repr(bound) | ||
x == v)), name + " out of bounds: " + repr(x) + ", " + repr(v) + ", " + repr(bound) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks unintentional here, but fine to me
@@ -200,7 +200,7 @@ def aevb_initial(): | |||
(NormalizingFlowGroup, {'flow': 'radial'}), | |||
(NormalizingFlowGroup, {'flow': 'radial-loc'}) | |||
], | |||
ids=lambda t: '{c} : {d}'.format(c=t[0].__name__, d=t[1]) | |||
ids=lambda t: '{c}: {d}'.format(c=t[0].__name__, d=t[1]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks unintentional here, but fine to me
@@ -307,7 +307,7 @@ def posterior_to_trace(self): | |||
size = 0 | |||
for var in varnames: | |||
shape, new_size = self.var_info[var] | |||
value.append(self.posterior[i][size : size + new_size].reshape(shape)) | |||
value.append(self.posterior[i][size: size + new_size].reshape(shape)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks unintentional here, but fine to me
@@ -436,7 +436,7 @@ def posterior_to_function(self, posterior): | |||
size = 0 | |||
for var in self.variables: | |||
shape, new_size = var_info[var.name] | |||
varvalues.append(posterior[size : size + new_size].reshape(shape)) | |||
varvalues.append(posterior[size: size + new_size].reshape(shape)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks unintentional here, but fine to me
I think sphinx doesn't allow a space between attributes and their description. I have tried to run a simple shell script to fix the issue.