Fix reparameterized gp.TP chi2 variable name
#3945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aloctavodia
reviewed
Jun 8, 2020
|
Hi @bwengals , since this is a small fix we can merge it for 3.9.0 as soon as you get the tests green. |
|
Of course, I totally forgot to check the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix, in
gp.TP, a parameter calledchi2_is automatically added to the model. It didn't have a unique name though, so there's an error if more than one Student's t process is in the model. This PR fixes this by changing the name totp_name+_chi2_. Does this need a test?