Remove awkward from theano import theano statements
#4054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on Review Jupyter notebook visual diffs & provide feedback on notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## master #4054 +/- ##
=======================================
Coverage 86.82% 86.82%
=======================================
Files 88 88
Lines 14154 14156 +2
=======================================
+ Hits 12289 12291 +2
Misses 1865 1865
|
|
I was working with @brandonwillard yesterday afternoon when trying to fix this, and I think it's good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the use of Theano import statements like
from theano import theano. This awkward type of import is only possible because thetheanomodule holds a reference to itself (for some unknown reason). Furthermore, these imports break PyMC3 when used with our Theano fork, because the fork doesn't introduce this anomalous circular reference.